UnitOfWork::clear() misses $eagerLoadingEntities

[BenMorel]

AFAICS, eager loading entities should be cleared as well when the UnitOfWork is cleared.

Actually, this is already the case on master!

[greg0ire]

phpcs has a weird complaint I don't understand… can you try running vendor/bin/phpcbf?

[BenMorel]

I'm not sure why this happens either... Locally, phpcs reports, and phpcbf fixes, thousands (!) of CS issues.

I'm not familiar with phpcs, but I suspect from the command:

php git-phpcs.phar origin/$TRAVIS_BRANCH...$TRAVIS_PULL_REQUEST_SHA

that it only reports issues on the line(s) modified by the PR. And due to the surrounding lines, there is not much I can do to fix this.

[greg0ire]

Maybe you could try aligning all equal signs, including in the surrounding lines?

[BenMorel]

Let's try this!

[greg0ire]

Hey! That actually worked! :)

[greg0ire]

Original commit: d070fc6

[greg0ire]

The commit above contains a similar change for $persisters, should it be applied too?

[BenMorel]

I have unfortunately no idea. For sure anything that contains a reference to an entity must be cleared, hence this PR, for the rest I'm not the right person to ask ;)

[greg0ire]

Let's wait for feedback from contributors that know the UOW better than I do.

[lcobucci]

@BenMorel thanks for the patch. The fix is 100% valid but we need a test to be able to get it merged 👍

[BenMorel]

@lcobucci Adding a test does not look like a trivial task, as there is no setter/getter for $eagerLoadingEntities.

Suggestions:

• test using reflection 🤢
• side-test using triggerEagerLoads(); this would require a complex setting, where you have to somehow set up an eager loading entity, and check that its EntityPersister is not invoked when calling triggerEagerLoads() after clear(); really not trivial, in comparison to the fix!

[SenseException]

Suggestion: You could use an EntityManager in a functional test to setup eagerloading entities and test the clear-method of the UOW.

[ostrolucky]

Test case added

[BenMorel]

@ostrolucky Thank you!

[guilhermeblanco]

This was an issue I found when i was working on ephemeral unit of work support. It also helps on freeing resources as eager loaded entities hang there forever. Patch on its own is great.

[ostrolucky]

I forgot to rename test case 😞 Let me know if I Should create new PR with just this change