Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete statements will not be created using clear #7861

Merged
merged 2 commits into from
Nov 15, 2019
Merged

Delete statements will not be created using clear #7861

merged 2 commits into from
Nov 15, 2019

Conversation

ferrastas
Copy link
Contributor

This is just a demo of an opened issue.

@ferrastas ferrastas mentioned this pull request Oct 9, 2019
Closed
lcobucci
lcobucci previously requested changes Oct 10, 2019
View reviewed changes
Copy link
Member

@lcobucci lcobucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a new test class with its own set of entities instead of modifying an existing one.

@lcobucci lcobucci self-requested a review October 10, 2019 07:48
@lcobucci lcobucci dismissed their stale review October 10, 2019 07:49

Actually, you're quite correct here. This scenario should have been there in the first place.

@ferrastas
Copy link
Contributor Author

Yep, looks like a missing test case of the original fix :P

@lcobucci lcobucci added this to the 2.6.5 milestone Nov 12, 2019
@ostrolucky ostrolucky self-assigned this Nov 15, 2019
@ostrolucky
Copy link
Member

I've pushed commit with better solution to fix #7758, without this regression

lcobucci
lcobucci suggested changes Nov 15, 2019
View reviewed changes
Copy link
Member

@lcobucci lcobucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ostrolucky thanks a lot for handling it. It's indeed a much better solution. I'll address these two tiny things and we're good to ship this.

tests/Doctrine/Tests/ORM/Functional/Ticket/GH7761Test.php Outdated Show resolved Hide resolved
lib/Doctrine/ORM/UnitOfWork.php Outdated Show resolved Hide resolved
ferrastas and others added 2 commits November 15, 2019 22:43
@ferrastas @lcobucci
Delete statements will not be created using clear.
ec93014
@ostrolucky @lcobucci
Restore ability to clear deferred explicit tracked collections
7d77984 
This was regression from #7862 which tried to respect tracking config
when clearing collections, but this logic can happen in UOW only,
PersistentCollection::clear is triggered too early to know what
is (going to be) persisted.

Fixes #7862
@lcobucci lcobucci merged commit 6a827d5 into doctrine:2.6 Nov 15, 2019
@lcobucci
Copy link
Member

@ferrastas @ostrolucky thank you very much 👍

@ferrastas
Copy link
Contributor Author

ferrastas commented Nov 19, 2019 •
edited

Thanks for fix it @ostrolucky 🏆

ahocquard added a commit to akeneo/pim-community-dev that referenced this pull request Nov 19, 2019
@ahocquard
TIP-1264: Upgrade doctrine libraries to fix bug @see doctrine/orm#7861
c51726e
ahocquard added a commit to akeneo/pim-community-dev that referenced this pull request Nov 19, 2019
@ahocquard
TIP-1264: Upgrade doctrine libraries to fix bug @see doctrine/orm#7861
aeb4d34
ahocquard added a commit to akeneo/pim-community-dev that referenced this pull request Nov 19, 2019
@ahocquard
TIP-1264: Upgrade doctrine libraries to fix bug @see doctrine/orm#7861
86b91e9
@arnolanglade arnolanglade mentioned this pull request Nov 20, 2019
Merged
@greg0ire greg0ire mentioned this pull request Nov 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ostrolucky ostrolucky ostrolucky left review comments

@lcobucci lcobucci lcobucci approved these changes

Assignees

@ostrolucky ostrolucky

Labels
Bug Regression
Projects
None yet
Milestone
2.6.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ferrastas @ostrolucky @lcobucci