Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix underscore naming strategy behaviour with numbers #7856

Merged

Conversation

lcobucci
Copy link
Member

@lcobucci lcobucci commented Oct 8, 2019

Fixes #7855

@lcobucci lcobucci added the Bug label Oct 8, 2019
@lcobucci lcobucci added this to the 2.6.5 milestone Oct 8, 2019
@lcobucci lcobucci requested a review from Ocramius October 8, 2019 09:43
@lcobucci lcobucci self-assigned this Oct 8, 2019
@lcobucci lcobucci force-pushed the fix/underscore-strategy-dont-work-with-numbers branch from 3246136 to 43cdbc3 Compare October 8, 2019 09:44
Ocramius
Ocramius previously approved these changes Oct 8, 2019
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for having separate commits for the added tests and the formatting changes 👍

@lcobucci lcobucci force-pushed the fix/underscore-strategy-dont-work-with-numbers branch from 43cdbc3 to c802bc4 Compare October 8, 2019 09:56
@lcobucci lcobucci merged commit 63513e9 into doctrine:2.6 Oct 8, 2019
@lcobucci lcobucci deleted the fix/underscore-strategy-dont-work-with-numbers branch October 8, 2019 10:06
@cobyl
Copy link

cobyl commented Nov 18, 2019

:/ broke my code. understand that behaviour before was wrongly, but that very deeply affect existing codebase :/ Not sure if in minor change should be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants