Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettified arrays in tool command orm:mapping:describe #7710

Merged
merged 1 commit into from Nov 16, 2019
Merged

Prettified arrays in tool command orm:mapping:describe #7710

merged 1 commit into from Nov 16, 2019

Conversation

rtek
Copy link
Contributor

@rtek rtek commented May 15, 2019

Adds JSON_PRETTY_PRINT to the orm:mapping:describe tool so that SymfonyStyle::table does not wrap excessively.

See before/after for examples.

before
after

@lcobucci lcobucci self-requested a review May 16, 2019 01:48
@greg0ire
Copy link
Member

greg0ire commented May 16, 2019

Please format your commit message according to these rules :

  • The commit message subject must be less than 50 characters and tell us what you did.
  • The commit message body should tell us why you did it. It is optional but highly recommended.

So:

Prettify arrays in orm:mapping:describe command

This will prevent excessive column width when using 
Symfony\Component\Console\Style\SymfonyStyle::table().

?

@rtek
Copy link
Contributor Author

rtek commented May 18, 2019

@greg0ire completed - thanks

greg0ire
greg0ire previously approved these changes May 18, 2019
SenseException
SenseException previously approved these changes May 26, 2019
@lcobucci
Copy link
Member

lcobucci commented Oct 2, 2019

@rtek this is awesome! However, it's an improvement, not a bug fix. It shall be sent to 2.7 instead 👍.

Would you please rebase your branch using 2.7 as reference?

@lcobucci lcobucci changed the base branch from 2.6 to 2.7 October 2, 2019 01:48
@lcobucci lcobucci added this to the 2.7.0 milestone Oct 2, 2019
@lcobucci
Copy link
Member

Good to go for 2.7.0, just needs a rebase.

lcobucci
lcobucci previously approved these changes Nov 16, 2019
This will prevent excessive column width and wrapping in the output which uses Symfony\Component\Console\Style\SymfonyStyle::table().
@lcobucci lcobucci merged commit 1b2daac into doctrine:2.7 Nov 16, 2019
@lcobucci
Copy link
Member

@rtek thanks!

@lcobucci lcobucci self-assigned this Nov 19, 2019
vilartoni added a commit to Emagister/doctrine-orm that referenced this pull request Jan 14, 2020
…gin-master

v2.7.0

[![Build Status](https://travis-ci.org/doctrine/orm.svg?branch=v2.7.0)](https://travis-ci.org/doctrine/orm)

This release solves Symfony 5.0 compatibility issues, some small improvements, and adds
various deprecation notices.

Please read carefully the [upgrade to 2.7
notes](https://github.com/doctrine/orm/blob/2.7/UPGRADE.md#upgrade-to-27) to know more
about the reasons and how to fix the deprecation messages.

---

- Total issues resolved: **1**
- Total pull requests resolved: **15**
- Total contributors: **10**

Deprecation
-----------

 - [7911: Be explicit about which Doctrine package in message](doctrine#7911) thanks to @lcobucci
 - [7909: Add deprecation messages](doctrine#7909) thanks to @lcobucci
 - [7901: Add deprecation warnings for 2.7.x](doctrine#7901) thanks to @lcobucci
 - [7701: Split and deprecate AbstractQuery#useResultCache()](doctrine#7701) thanks to @someniatko

CI
--

 - [7904: Make sure composer files are valid](doctrine#7904) thanks to @greg0ire
 - [7600: &doctrine#91;2.7&doctrine#93; CI: Test against PHP 7.4snapshot instead of nightly (8.0)](doctrine#7600) thanks to @Majkl578

Improvement
-----------

 - [7876: Fix compat of commands with Symfony 5](doctrine#7876) thanks to @nicolas-grekas
 - [7829: Skip Paginator LIMIT subquery and WHERE IN if query do not have LIMIT](doctrine#7829) thanks to @Seb33300
 - [7723: Allow Symfony 5.0](doctrine#7723) thanks to @nicolas-grekas
 - [7710: Prettified arrays in tool command orm:mapping:describe](doctrine#7710) thanks to @rtek
 - [7340: Fix config template for PHPUnit >= 7.2](doctrine#7340) thanks to @guilliamxavier

BC Break,Improvement
--------------------

 - [7863: Paginator: Skip limit subquery if not required](doctrine#7863) thanks to @Seb33300

Documentation
-------------

 - [7382: Update homepage](doctrine#7382) thanks to @Majkl578

Bug
---

 - [7326: Cherry-pick doctrine#7307 to fix remaining usages of deprecated ClassLoader and Inflector from doctrine/common](doctrine#7326) thanks to @nicolas-grekas
 - [7079: Fix getJoinTableName for sqlite with schema attribute](doctrine#7079) thanks to @mairo744

BC Break,Deprecation,Improvement
--------------------------------

 - [6803: Deprecation of EntityManager copy method](doctrine#6803) thanks to @SenseException
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants