Fix getJoinTableName to care about schema emulation #5785
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptkoz
approved these changes
Nov 23, 2019
|
There are conflicts, this needs a rebase. Also, the build is failing since we renamed the project. |
|
Please improve your commit message according to the contributing guide. |
|
Looks like #7079 solved this and we just need to get it into |
|
@pamelus apparently you experienced this, please confirm that it does fix the issue so that we can close this. |
|
Confirmed. I'm unable to reproduce using 2.7.0 (4d763ca) from packagist, while it's still reproducible on 2.6.4. Thanks! |
|
Nice, thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5784.
Not sure if
$platform = new \Doctrine\DBAL\Platforms\SqlitePlatform;is the best way to use another platform in tests.