Discriminator value could be an integer #11425
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change on line 399 was introduced in a merge up: 5a40b99 🤔 |
greg0ire
previously approved these changes
Apr 28, 2024
SenseException
previously approved these changes
Apr 28, 2024
|
@prohalexey Does this PR fix #11341? Does it make sense to add the unit tests which are suggested in this issue? |
Yes, please do 🙏 |
|
@prohalexey can you please incorporate the unit tests suggested in #11341 ? |
…discriminator with tests.
|
Tests have been added and the code has been changed to a more accurate version. @greg0ire pls, look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same as
Without casting a TypeError is raised.