Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docs to show QueryBuilder::setParameters with array instead of ArrayCollection #11295

Closed
wants to merge 1 commit into from

Conversation

pableu
Copy link

@pableu pableu commented Feb 22, 2024

@greg0ire
Copy link
Member

greg0ire commented Feb 23, 2024

Please kindly squash your commits together. If you don't, we'll try to remember to do it for you but it's best if you save us this trouble.

How to do that?

  1. git rebase -i origin/2.18.x, assuming origin is a git remote that points to this repository, and not your fork. If you're not sure what your remotes are, run git remote -vvv, there should be your fork and the holy/reference/base/origin/whatever-you-call-it repository.
  2. A window will show up with many lines, replace pick with fixup on every line but the first one
  3. Close your editor, git should do its magic, and you should end up with one commit
  4. Use git push --force to overwrite what you already push. Don't forget the --force option otherwise git will try to merge both things together.

@pableu
Copy link
Author

pableu commented Feb 23, 2024

Squashed :-)

Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, we would promote the usage of a deprecated API. I don't think that this is what we want.

@greg0ire
Copy link
Member

greg0ire commented Mar 3, 2024

Indeed, see the original discussion

@greg0ire greg0ire closed this Mar 3, 2024
@pableu pableu deleted the querybuilder-array-docs branch March 3, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants