Factor out finding discriminator values for a class #11213
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpdude
force-pushed
the
factor-out-discr-values
branch
from
43f799c
to
0507785
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #11200, I noticed that almost the same bug that was fixed in the
SqlWalkerhad been fixed in #10643 for theSingleTablePersister.The underlying question is what the possible discriminator column values may be for a given class.
This PR is a refactoring that moves this logic to an internal method in
ClassMetadata, and uses it from both other places.(This is a draft for the time being. Waiting for #11200 to be merged and merged up, then this PR will keep only the actual refactoring for 3.1.x.)