Make sure tests from #7837 are actually run #10433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpdude
changed the title
mpdude
changed the title
mpdude
changed the title
|
🤔 codecov says the Coverage is not affected |
|
For a start, can you confirm my findings? What exactly does codecov measure? |
|
I think this comment anticipated what actually happened, we’re testing the walker thing but did not add the limit. |
|
#9519 already fixed this problem for another test, but missed the one I found |
|
Reviewed all other tests that deal with the Paginator and they seem fine. |
greg0ire
approved these changes
Jan 21, 2023
|
Thanks @mpdude ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when I remove this line
https://github.com/Ocramius/doctrine2/blob/98e557b68eeecd7f266f1e4628007aed2714026c/lib/Doctrine/ORM/Tools/Pagination/Paginator.php#L169
added in #7837 the corresponding tests still pass.
This is because the relevant branch in
\Doctrine\ORM\Tools\Pagination\Paginator::getIterator()is not reached. A new necessary condition was added briefly afterwards in #7863, and that caused the tests to miss the relevant section.With the change suggested here, removing the line will make the specific test fail again.