Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enums are considered as changes when Entity is fetched through query. #10245

Closed
wants to merge 16 commits into from

Conversation

Warxcell
Copy link
Contributor

@Warxcell Warxcell commented Nov 22, 2022

Test case that reproduces the behaviour.

@Warxcell Warxcell marked this pull request as draft November 22, 2022 17:05
@Warxcell Warxcell changed the title Enums are considered as changes when multiple flushes. Enums are considered as changes when Entity is fetched through query. Nov 22, 2022
@Warxcell Warxcell marked this pull request as ready for review November 22, 2022 21:19
@kbond
Copy link
Contributor

kbond commented Nov 23, 2022

I thought #10074 fixed but maybe not?

@Warxcell
Copy link
Contributor Author

I thought #10074 fixed but maybe not?

Ah, could be, but its not released yet.

@michnovka
Copy link
Contributor

I will have a look into this today in few hours

@michnovka
Copy link
Contributor

Hmm, I dont get why

$card = $this->_em->find(CardWithDefault::class, $cardId);

returns Proxy class for CardWithDefault. suit is not initialized it seems. And I am not sure whether passing proxy class to computeChangeSet is supported. @HypeMC @greg0ire can you have a look please?

@Warxcell
Copy link
Contributor Author

Hmm, I dont get why

$card = $this->_em->find(CardWithDefault::class, $cardId);

returns Proxy class for CardWithDefault. suit is not initialized it seems. And I am not sure whether passing proxy class to computeChangeSet is supported. @HypeMC @greg0ire can you have a look please?

Ok, I will create exactly our use case then, for accuracy.

@Warxcell
Copy link
Contributor Author

Ok, seems its indeed resolved with #10074 , closing this.

@Warxcell Warxcell closed this Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants