Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use more precise phpdoc #10238

Merged
merged 1 commit into from Nov 20, 2022
Merged

Use more precise phpdoc #10238

merged 1 commit into from Nov 20, 2022

Conversation

VincentLanglet
Copy link
Contributor

Will solve phpstan/phpstan-doctrine#393

@return $this

is more precise than self.

@greg0ire should I target 2.14 ?

@greg0ire
Copy link
Member

Yes

@VincentLanglet VincentLanglet mentioned this pull request Nov 19, 2022
Closed
@VincentLanglet VincentLanglet changed the base branch from 2.13.x to 2.14.x November 19, 2022 12:48
@VincentLanglet
Copy link
Contributor Author

Yes

Done

@greg0ire
Copy link
Member

greg0ire commented Nov 19, 2022 •
edited

🤔 Looks like the latest release of doctrine/persistence breaks the build 😩

@greg0ire
Copy link
Member

Working on that at #10239

@derrabus
Copy link
Member

Please rebase.

@derrabus derrabus added this to the 2.14.0 milestone Nov 20, 2022
@VincentLanglet
Copy link
Contributor Author

Thanks @greg0ire

@greg0ire greg0ire merged commit 5a7fce1 into doctrine:2.14.x Nov 20, 2022
@greg0ire
Copy link
Member

And thank you @VincentLanglet !

@VincentLanglet VincentLanglet deleted the lockMode branch November 20, 2022 21:20
@github-actions github-actions bot mentioned this pull request Dec 19, 2022
Merged
@ruudk ruudk mentioned this pull request Nov 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
Static Analysis
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@VincentLanglet @greg0ire @derrabus