Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run only relevant workflows #10134

Merged
merged 1 commit into from Oct 15, 2022
Merged

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented Oct 15, 2022

The downside of this is that we will have to tweak the settings so that no job is required anymore.
The upside is that builds should be faster, and less resource-intensive. Note that this particular pull request is going to run all the workflows, as I'm touching the workflow files.

Inspired by #4919, prompted by https://afup.org/talks/4016-papa-et-maman-nettoient-l-internet

derrabus
derrabus previously approved these changes Oct 15, 2022
The downside of this is that we will have to tweak the settings so that
no job is required anymore.
The upside is that builds should be faster, and less resource-intensive.
@greg0ire greg0ire merged commit 16e2565 into doctrine:2.13.x Oct 15, 2022
@greg0ire greg0ire deleted the lighter-builds-💚🌍 branch October 15, 2022 09:48
@greg0ire
Copy link
Member Author

Woops: #10135

@mabar
Copy link

mabar commented Oct 15, 2022

You can have jobs required even when they are cancelled or skipped. And you can also manage them via workflow file instead of UI
Feel free to copy my reusable workflow from here
https://github.com/orisai/github-workflows/blob/v1.x/docs/README.md#status-check-for-branch-protection

@greg0ire
Copy link
Member Author

@mabar I don't understand; what would that extra workflow do in the case of #10126, where there are no checks: #10126

Does the list inside needs need to be dynamic? Feel free to open a PR, it might be easier to discuss that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants