Fix using enums with the QueryBuilder

[HypeMC]

Fixes #10057.

After upgrading to version 2.13.2 I started getting the following error:

App\Enum\TestEnum::from(): Argument #1 ($value) must be of type string, App\Enum\TestEnum given

It happens when an enum is used with the QueryBuilder, eg:

$testRepository
    ->createQueryBuilder('t')
    ->where('t.enum = :type')
    ->setParameter('type', TestEnum::Foo)
    ->getQuery()->getResult()
;

Caused by #10041.

Since my knowledge of the ORM code base is limited I'm not sure if this is the best place to fix the bug, so any suggestions are appreciated.

[greg0ire]

Cc @michnovka

[michnovka]

Ill review this on Sunday and check how my PR caused this issue and confirm this is a good fix. thx for waiting

…

On Thu, Sep 22, 2022, 23:30 Jakub Janata ***@***.***> wrote: ***@***.**** approved this pull request. — Reply to this email directly, view it on GitHub <#10058 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD6JI74VTUWDKYB63WCVXWLV7TFY3ANCNFSM6AAAAAAQTKHFBE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[michnovka]

This is a good fix, and I also believe we now cover all enum hydrator test cases, so no such regression bugs should occur in the future. Thanks @HypeMC

[greg0ire]

Thanks @HypeMC !

[tip2tail]

Hello, when can we expect this to be released?

[greg0ire]

Soon ™️

I think we should try to batch #10059 in the same release, and it looks ready.

[trsteel88]

There is a further issue here. hasChangedField is always returning true for an enum regardless of whether it actually changed.

When using hasChangedField('status') it shows it as changed when it hasn't.

[trsteel88]

Just further to my last comment, when dumping the old/new values. The difference is that getOldValue() gives the enum object whereas getNewValue() return the enum's value. My guess is the comparison is failing because these should both be the enum object?

[michnovka]

@trsteel88 there is a separate PR for this issue #10074