Skip to content

Commit

Permalink
Remove fragile assertions
Browse files Browse the repository at this point in the history
RuntimePublicReflectionProperty has been deprecated in favor of
RuntimeReflectionProperty.

Let us use a more robust assertion.
  • Loading branch information
greg0ire committed Nov 19, 2022
1 parent fc3201b commit edf1b7c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion composer.json
Expand Up @@ -32,7 +32,7 @@
"doctrine/inflector": "^1.4 || ^2.0",
"doctrine/instantiator": "^1.3",
"doctrine/lexer": "^1.2.3",
"doctrine/persistence": "^2.4 || ^3",
"doctrine/persistence": "^2.4 || ^3.1",
"psr/cache": "^1 || ^2 || ^3",
"symfony/console": "^3.0 || ^4.0 || ^5.0 || ^6.0",
"symfony/polyfill-php72": "^1.23",
Expand Down
4 changes: 2 additions & 2 deletions tests/Doctrine/Tests/ORM/Functional/ValueObjectsTest.php
Expand Up @@ -19,8 +19,8 @@
use Doctrine\ORM\Mapping\MappingException;
use Doctrine\ORM\Mapping\ReflectionEmbeddedProperty;
use Doctrine\ORM\Query\QueryException;
use Doctrine\Persistence\Reflection\RuntimePublicReflectionProperty;
use Doctrine\Tests\OrmFunctionalTestCase;
use ReflectionProperty;

use function class_exists;
use function sprintf;
Expand Down Expand Up @@ -53,7 +53,7 @@ public function testMetadataHasReflectionEmbeddablesAccessible(): void
);
} else {
self::assertInstanceOf(
RuntimePublicReflectionProperty::class,
ReflectionProperty::class,
$classMetadata->getReflectionProperty('address')
);
}
Expand Down

0 comments on commit edf1b7c

Please sign in to comment.