Use alternatives for features deprecated in PHPUnit 8

[olvlvl]

Q	A
Type	improvement
BC Break	no

Summary

• The method assertInternalType() is deprecated, use alternatives such as assertIsInt(). Deprecate assertInternalType() and assertNotInternalType() sebastianbergmann/phpunit#3369
• The $delta parameter of assertEquals() is deprecated, use assertWithDelta() instead. Deprecate optional parameters of assertEquals() and assertNotEquals() sebastianbergmann/phpunit#3341

[olvlvl]

🤔 This test was not modified.

1) Doctrine\ODM\MongoDB\Tests\Functional\LockTest::testLockTimestampThrowsException

Failed asserting that exception of type "Doctrine\ODM\MongoDB\LockException" is thrown.

[greg0ire]

Should you really target master since there is no BC-break (disclaimer, I don't know where we are regarding the merge down vs merge up policy, but IIRC only the ORM still uses a merge down policy)?

[alcaeus]

We definitely merge up in ODM. I’m not going to update 2.0 for PHPUnit 9, so this is fine for master.

As for the failing test, this one fails once in a while. I’ve restarted the offending build.

[greg0ire]

Still failing. My turn to restart it :)

[malarzm]

Thanks @olvlvl!