Cleanup: old php versions compat cleanup #23
Merged
+149
−283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: tests can only succeed once this is in |
Ocramius
force-pushed
the
cleanup/old-php-versions-compat-cleanup
branch
from
9d29254 to
874097c
Compare
|
This can't pass on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the ugly hacks required for some specific older PHP versions, replacing them with the assumptions that PHP 5.6.0+ is going to be used.
Note: this is supposed to happen on
master, which is going to be1.1.0.1.0.xis still going to be supported.