Merge 1.5.x into 2.0.x #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like the "of object" part is no longer mentioned in recent PHPStan versions.
Using &$error inside the use clause of a Closure to make a variable defined inside the closure available outside should be fine. Psalm seems to be OK with it on the playground, which uses the master branch, which must contain a fix, but I did not find which commit exactly on master fixes it.
Adapt ignore error message
PHP 8.3 support tests
* 1.5.x: Make data providers static (doctrine#106) Doctrine CS 12 (doctrine#107) Bump CI workflows (doctrine#105) Ignore issue about undefined variable Adapt ignore error message PHP 8.3 support tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.