Added TraceLogger to get backtrace for executed queries #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-1036 We use Jira to track the state of pull requests and the versions they got |
| { | ||
| $backtrace = array(); | ||
|
|
||
| foreach ($trace as $index => $line) { |
There was a problem hiding this comment.
Why not simply storing the trace and that's it? Dumping a trace is a separate concern
greg0ire
reviewed
Nov 17, 2017
| } | ||
| } | ||
|
|
||
| private function getBactrace() |
There was a problem hiding this comment.
Should be "Backtrace" with a "k"
|
No more loggers, please. A PSR-3 adapter would be much more welcome. |
|
Closing this as per @morozov's comment. |
|
Implemented in doctrine/DoctrineBundle#954 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a TraceLogger that returns a backtrace for the executed query.
The backtrace returns the last 10 frames, and it also formats the frames for easy reading