Add PHP 8.4 to CI #6348
Open
Add PHP 8.4 to CI #6348
+14,058
−36,157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reate-schema Remove AbstractSchemaManager::createSchema()
…tected Make internal Comparator methods protected
Remove property-based schema comparison APIs
…ftovers Remove leftovers of handling foreign keys on non-InnoDB engines for MySQL
…traint-name Introspect default constraint name
Remove conditional comments for MySQL older than 5.1.16
Remove support for "unique" and "check" column properties
…-schema Remove SchemaDiff::$fromSchema
Remove support for renaming tables via TableDiff
…lt-constraint-leftovers Remove leftovers of renaming default contraints
Remove TableDiff::$name and getName()
…perties Mark ColumnDiff properties as private and read-only
…handling-workaround Remove workaround for PHP bug in PostgreSQL exception handler
* 3.8.x: README: The 4.0 branch is stable Move type coverage badge (doctrine#6295)
Corrected typo
Update UPGRADE.md
…octrine#6305) | Q | A |------------- | ----------- | Type | improvement (documentation) | Fixed issues | none
* 3.8.x: [3.8.x] AbstractPlatform - allow any string in interval for date interval expression (doctrine#6302)
* 3.8.x: PHPStan 1.10.58, PHPCS 3.9.0 (doctrine#6307)
* 3.8.x: Add gssencmode option to connection string for PgSQL & PDO PgSQL driver (doctrine#6320)
* 3.8.x: Bump CI workflows (doctrine#6323) Make all mapped database types case insensitive (doctrine#6321)
The list of reserved characters for cache key names was missing ':'
Update UPGRADE.md
| Q | A |------------- | ----------- | Type | improvement | Fixed issues | none #### Summary Page: https://www.doctrine-project.org/projects/doctrine-dbal/en/4.0/reference/types.html#bigint The `int`-mapping needs to be added at https://www.doctrine-project.org/projects/doctrine-orm/en/3.1/reference/basic-mapping.html#doctrine-mapping-types too! What is the right version information? Is it only working if you have DBAL 4 **and** ORM 3?
To reduce Algolia operations and indexes older versions get removed
Remove older versions from the docs
* 3.8.x: Add MariaDB 11.3 to the test matrix (doctrine#6342) Spell which properly Fix double quote used wrongly for literal value in SqliteSchemaManager (doctrine#6325)
|
🤔 isn't this a bit premature? |
I don't think so. We can start running the CI against PHP 8.4, but if we do, we should test all extensions and not just SQLite. |
|
@derrabus updated for all extentions |
derrabus
requested changes
Apr 3, 2024
| @@ -299,6 +302,9 @@ jobs: | |||
| - php-version: "8.3" | |||
| mariadb-version: "11.2" | |||
| extension: "pdo_mysql" | |||
| - php-version: "8.4" | |||
| mariadb-version: "11.2" | |||
| extension: "pdo_mysql" | |||
There was a problem hiding this comment.
We need to test with both extensions!
| @@ -370,6 +376,9 @@ jobs: | |||
| - php-version: "8.3" | |||
| mysql-version: "8.0" | |||
| extension: "pdo_mysql" | |||
| - php-version: "8.4" | |||
| mysql-version: "8.0" | |||
| extension: "pdo_mysql" | |||
|
And please target 3.8.x for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary