fix(DB2): Instance of DateTimeType cannot be converted to string #6313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tofandel
changed the title
A test would be good though. How would I know we're actually fixing an issue here and how can I be sure, we're not reintroducing that issue again in the future? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue found in https://github.com/doctrine/dbal/pull/6280/files#r1467725285
Summary
$column['type']is an instance of a Dbal Type which cannot be converted to a string (because they do not have a __toString methodNo idea when this should occur or how to write a test for it, but I just know this piece of code throws an error when it does run