Make column and index renaming configurable #6300
Open
+88
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ausi
commented
Feb 6, 2024
src/Platforms/MySQL/Comparator.php
Outdated
| @@ -30,11 +31,12 @@ public function __construct( | |||
| parent::__construct($platform); | |||
| } | |||
|
|
|||
| public function compareTables(Table $oldTable, Table $newTable): TableDiff | |||
| public function compareTables(Table $oldTable, Table $newTable, ?ComparatorConfig $config = null): TableDiff | |||
There was a problem hiding this comment.
Is this considered to be a BC break?
If so, should I use func_get_arg() or a setConfig() method instead?
(I’d not be a fan of a setConfig() method as this would introduce state to the Comparator)
There was a problem hiding this comment.
As I mentioned in the issue, Comparator is indeed an extensible class, so changing the public signature is a breaking change, though likely a very low impact one
There was a problem hiding this comment.
So, should I add a setConfig() method to the Comparator?
There was a problem hiding this comment.
I think it would be best yes
ausi
force-pushed
the
feature/rename-columns-configurable
branch
from
b663bfe
to
d0c8602
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Makes column and index rename detection of the
Comparatorconfigurable, as suggested in #6299 (comment)