fix(PostgreSQL omit dropped columns in getListTableColumnsSQL (pg_att… #6249
+58
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ribute table) to avoid ........pg.dropped.x....... Signed-off-by: Kamil Michalak <k.michalak@kstudio.pl>
|
Thank you. Please add a functional test that covers your change. |
…ribute table) to avoid ........pg.dropped.x....... - test Signed-off-by: Kamil Michalak <k.michalak@kstudio.pl>
…ribute table) to avoid ........pg.dropped.x....... - test fix Signed-off-by: Kamil Michalak <k.michalak@kstudio.pl>
…ribute table) to avoid ........pg.dropped.x....... - test fix Signed-off-by: Kamil Michalak <k.michalak@kstudio.pl>
|
@derrabus please review. |
derrabus
reviewed
Dec 22, 2023
Comment on lines
+35
to
+48
| public function testPgSqlPgAttributeTable(): void | ||
| { | ||
| $platform = $this->connection->getDatabasePlatform(); | ||
|
|
||
| if (!$platform instanceof PostgreSQLPlatform) { | ||
| self::markTestSkipped('Test does work on PostgreSQL only.'); | ||
| } | ||
|
|
||
| try { | ||
| $this->connection->executeQuery('Select attisdropped from pg_attribute Limit 1')->fetchOne(); | ||
| } catch (Throwable $e) { | ||
| self::fail("Column attisdropped not exists in pg_attribute table"); | ||
| } | ||
| } |
There was a problem hiding this comment.
What is the purpose of this test?
|
What is the status here? I have now also stumbled across this bug and the changes in this pull request have fixed it locally. Is the PR still in development? |
Yes, please do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ribute table) to avoid ........pg.dropped.x.......
Summary
Avoid fetching deleted columns for tables structure