Simplify Oracle CI testing #6220
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Converted to draft as long as the CI is failing. |
|
Thanks. Any idea why? In atk4/data@6c59956 the |
|
I don't really have time to investigate this right now, sorry. 😓 |
mvorisek
force-pushed
the
simplify_oracle_testing
branch
2 times, most recently
from
5bd8692
to
87c244d
Compare
mvorisek
force-pushed
the
simplify_oracle_testing
branch
2 times, most recently
from
43bf7a0
to
abd5bfc
Compare
mvorisek
force-pushed
the
simplify_oracle_testing
branch
from
abd5bfc
to
31fdae4
Compare
mvorisek
commented
Feb 24, 2024
| @@ -55,15 +55,7 @@ public static function fromConnectionParameters(array $params): self | |||
| $connectData = []; | |||
|
|
|||
| if (isset($params['servicename']) || isset($params['dbname'])) { | |||
There was a problem hiding this comment.
Based on:
- Provide
FREESID (together with currentXE) gvenzl/oci-oracle-xe#238 (comment) - Ability to set ORACLE_SID gvenzl/oci-oracle-free#34
the service name should be the default, SID is internal DB identifier, but service name is more or less like "DB name", does support aliasing or clustering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As discussed in #6217 (comment) thanks to gvenzl/oci-oracle-xe#238.