Update to doctrine/coding-standard 10 on 4.0.x #5632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
reviewed
Aug 29, 2022
src/Cache/QueryCacheProfile.php
Outdated
Comment on lines
25
to
26
| private readonly ?string $cacheKey = null, | ||
| private readonly ?CacheItemPoolInterface $resultCache = null | ||
| private readonly string|null $cacheKey = null, | ||
| private readonly CacheItemPoolInterface|null $resultCache = null, |
There was a problem hiding this comment.
I don't believe that union types should be enforced over the nullable ones. We discussed it recently in another thread.
There was a problem hiding this comment.
Can you please open an issue on the CS repo? I think that's were the issue needs to be discussed.
There was a problem hiding this comment.
Done: doctrine/coding-standard#288.
|
Psalm suddenly chokes on Psalm 5.0.0-beta1 doesn't have the issue but comes with other errors… |
|
I'll revert the change about union types that way we don't have to wait for the resolution of doctrine/coding-standard#288 to merge this. |
One rule is excluded temporarily, pending a discussion on the standard repository.
They are not supported by Psalm yet.
morozov
approved these changes
Aug 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be followed by a
git merge origin/3.5.x --strategy ours