Fix database detection on SQLite with PORTABILITY_EMPTY_TO_NULL #5617
+10
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is primarily a workaround while there are two fundamental issues:
Connection::getDatabase()
which is used internally. It cannot be properly implemented in a portable way by definition.dbal/src/Schema/OracleSchemaManager.php
Lines 235 to 236 in 279f365
Returning
main
instead of an empty string as the SQLite database name was originally proposed in #5046.Fixes #5615.