Fix DropSchemaObjectsSQLBuilder issues #5604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
force-pushed
the
issues/5598-drop-sequence
branch
from
c3d0706
to
86e6d6a
Compare
Although `CreateSchemaSqlCollector` creates the namespaces declared in the schema, `DropSchemaObjectsSQLBuilder` does not drop them. We will keep it the same in `DropSchemaObjectsSQLBuilder` for backward compatibility.
morozov
force-pushed
the
issues/5598-drop-sequence
branch
from
86e6d6a
to
add3ceb
Compare
morozov
changed the title
morozov
force-pushed
the
issues/5598-drop-sequence
branch
from
add3ceb
to
98ab59d
Compare
When dropping a schema, the DBAL explicitly drops all schema sequences, even if they are owned by one of the tables being dropped. As a workaround for the regression, we will drop sequences first, which is how it is implemented in `DropSchemaSqlCollector`. Co-authored-by: HypeMC <hypemc@gmail.com>
morozov
force-pushed
the
issues/5598-drop-sequence
branch
from
98ab59d
to
645ea4e
Compare
greg0ire
approved these changes
Aug 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CreateSchemaSqlCollectorcreates the namespaces declared in the schema,DropSchemaObjectsSQLBuilderdoes not drop them. We will keep it the same inDropSchemaObjectsSQLBuilderfor backward compatibility.DropSchemaSqlCollector.The newly added
testDropWithAutoincrement()is intended to test the second issue but covers the first one as well. It would fail without the corresponding fix if run as part of the test suite.Fixes #5598.
Closes #5600.