Allow overriding the constructor #5528
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the flyweight pattern has been removed, it should be possible.
stof
reviewed
Jul 21, 2022
| @@ -48,13 +48,6 @@ abstract class Type | |||
|
|
|||
| private static ?TypeRegistry $typeRegistry = null; | |||
|
|
|||
| /** | |||
| * @internal Do not instantiate directly - use {@see Type::addType()} method instead. | |||
There was a problem hiding this comment.
A type registered through addType is still required to have no arguments in the constructor. We still need a check for that.
There was a problem hiding this comment.
It looks like we need to deprecate the static Type methods that accept string $className in favor of TypeRegistry and the corresponding counterparts which accept Type $type.
Only after the deprecated methods have been removed, this constraint could be dropped.
|
Given that there are unresolved dependencies not being actively worked on (see #5530 (comment)), I propose that we close this pull request for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #5036, prompted by doctrine/DoctrineBundle#1246 (comment)