Deprecate AbstractPlatform::hasNative*Type() and Type::requiresSQLCommentHint() #5509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
approved these changes
Jul 16, 2022
|
Hi 👋 The |
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Jul 20, 2022
…eGuidType()` (derrabus) This PR was merged into the 5.4 branch. Discussion ---------- [DoctrineBridge] Avoid calling `AbstractPlatform::hasNativeGuidType()` | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Follows doctrine/dbal#5509, alternative to doctrine/dbal#5518 | License | MIT | Doc PR | N/A `AbstractPlatform::hasNativeGuidType()` has been deprecated in Doctrine DBAL. This PR inlines the logic of that method where we need it. Furthermore, I took the liberty to refactor the corresponding tests a little. We don't really need to mock `AbstractPlatform` because we can work with actual instances. This also allows us to test the behavior of our implementation on different platforms. Commits ------- 5d882ce Avoid calling AbstractPlatform::hasNativeGuidType()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type::requiresSQLCommentHint()is not needed as of #5107.AbstractPlatform::hasNative*Type()is only used to implementType::requiresSQLCommentHint().