Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nest deprecations for 3.4 under 3.4 #5279

Merged
merged 1 commit into from Feb 15, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions UPGRADE.md
Expand Up @@ -8,7 +8,7 @@ awareness about deprecated code.

# Upgrade to 3.4

# Deprecated `AbstractPlatform` schema introspection methods
## Deprecated `AbstractPlatform` schema introspection methods

The following schema introspection methods have been deprecated:

Expand All @@ -19,22 +19,22 @@ The following schema introspection methods have been deprecated:

The queries used for schema introspection are an internal implementation detail of the DBAL.

# Deprecated `collate` option for MySQL
## Deprecated `collate` option for MySQL

This undocumented option is deprecated in favor of `collation`.

# Deprecated `AbstractPlatform::getListTableConstraintsSQL()`
## Deprecated `AbstractPlatform::getListTableConstraintsSQL()`

This method is unused by the DBAL since 2.0.

# Deprecated `Type::getName()`
## Deprecated `Type::getName()`

This will method is not useful for the DBAL anymore, and will be removed in 4.0.
As a consequence, depending on the name of a type being `json` for `jsonb` to
be used for the Postgres platform is deprecated in favor of extending
`Doctrine\DBAL\Types\JsonType`.

# Deprecated `AbstractPlatform::getColumnComment()` and `AbstractPlatform::getDoctrineTypeComment()`
## Deprecated `AbstractPlatform::getColumnComment()` and `AbstractPlatform::getDoctrineTypeComment()`

DBAL no longer needs column comments to ensure proper diffing. Note that both
methods should probably have been marked as internal as these comments were an
Expand Down