Drop Type::getName() #5208
Merged
Drop Type::getName() #5208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
force-pushed
the
drop-getName
branch
3 times, most recently
from
f0a7298
to
20615e3
Compare
greg0ire
commented
Jan 25, 2022
| /** | ||
| * Gets the name of this type. | ||
| * | ||
| * @todo Needed? |
morozov
reviewed
Jan 25, 2022
greg0ire
force-pushed
the
drop-getName
branch
from
20615e3
to
c826c18
Compare
morozov
approved these changes
Jan 26, 2022
Merged
This was referenced May 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #5107, this method serves little to no purpose. Let's avoid duplicating the name in the method and in the type registry.