Workaround for "mixed is a reserved word" error #5053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternatively, we could just remove Symfony Cache 6 from the dev dependencies. We don't test for Symfony compatibility, we only install Symfony Cache because we need a cache implementation. So using 5.4 should be fine, just as we pin to 4.4 on the 2.13 branch. |
Working around a bug in the static analysis tool by suppressing the error looks like the right approach to me. UPD: I see that it's not really a bug but rather a known behavior. Anyways, the suppression is fine for now. |
morozov
approved these changes
Nov 30, 2021
fbourigault
added a commit
to fbourigault/Propel2
that referenced
this pull request
Jan 4, 2022
Symfony 6 added return types to most of it's signatures. This is reported as ReservedWords by Psalm. See vimeo/psalm#7026 and doctrine/dbal#5053 for more context.
fbourigault
added a commit
to fbourigault/Propel2
that referenced
this pull request
Jan 4, 2022
Symfony 6 added return types to most of it's signatures. This is reported as ReservedWords by Psalm. See vimeo/psalm#7026 and doctrine/dbal#5053 for more context.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR suppresses a Psalm error that appeared after the Symfony 6 release. I've reported the issue as vimeo/psalm#7026.