-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for Doctrine Cache #4626
Conversation
ddf3588
to
9732e07
Compare
9732e07
to
371edb5
Compare
@derrabus I believe you can proceed here. |
371edb5
to
c08fd1e
Compare
The PR is ready. 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also adapt caching.rst in the docs (https://github.com/doctrine/dbal/blob/4.0.x/docs/en/reference/caching.rst) where $config->setResultCacheImpl($cache);
is used in an example.
@SenseException The documentation will be fixed with #4652. Let's keep it out of this PR. |
Let's keep documentation in sync with the code within each commit. Since the PR removes a method, it must remove it from the documentation as well. |
This comment has been minimized.
This comment has been minimized.
I still see that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@morozov The changes in caching.rst are already merged and up-merged into 4.0.x. Or do you refer to other occurrences of the method calls?
I was referring to dbal/docs/en/reference/caching.rst Lines 11 to 14 in c08fd1e
If this has been addressed in |
c08fd1e
to
f18ddba
Compare
I've rebased my PR onto 4.0.x. The docs should be correct now. 🙂 |
Thanks, @derrabus! |
Summary
This PR resolves the deprecations introduced by #4620 and #4624.