Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-4503] Mark OracleSchemaManager methods internal #4584

Merged
merged 1 commit into from Apr 4, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions UPGRADE.md
Expand Up @@ -16,6 +16,10 @@ Use `AbstractSchemaManager::listSchemaNames()` instead.

`PostgreSQLSchemaManager::getExistingSchemaSearchPaths()` and `::determineExistingSchemaSearchPaths()` have been marked internal.

## `OracleSchemaManager` methods marked internal.

`OracleSchemaManager::dropAutoincrement()` has been marked internal.

## Deprecated `AbstractPlatform::getReservedKeywordsClass()`

Instead of implementing `getReservedKeywordsClass()`, `AbstractPlatform` subclasses should implement
Expand Down
2 changes: 2 additions & 0 deletions src/Schema/OracleSchemaManager.php
Expand Up @@ -264,6 +264,8 @@ public function createDatabase($database)
}

/**
* @internal The method should be only used from within the OracleSchemaManager class hierarchy.
*
* @param string $table
*
* @return bool
Expand Down