Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Doctrine Coding Standard to 7.0 #3847

Merged
merged 4 commits into from
Jan 28, 2020
Merged

Update Doctrine Coding Standard to 7.0 #3847

merged 4 commits into from
Jan 28, 2020

Conversation

morozov
Copy link
Member

@morozov morozov commented Jan 24, 2020

Q A
Type improvement
BC Break no

@morozov morozov force-pushed the coding-standard-7 branch 3 times, most recently from 54789cc to ab8acba Compare January 25, 2020 23:09
@morozov morozov added this to the 4.0.0 milestone Jan 25, 2020
@morozov morozov mentioned this pull request Jan 27, 2020
Closed
@morozov morozov removed the WIP label Jan 27, 2020
carusogabriel
carusogabriel approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@carusogabriel carusogabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@morozov morozov merged commit 77087e7 into doctrine:master Jan 28, 2020
@morozov morozov deleted the coding-standard-7 branch January 28, 2020 15:21
@morozov morozov self-assigned this Jan 28, 2020
@morozov morozov mentioned this pull request May 3, 2020
Merged
@morozov morozov modified the milestones: 4.0.0, 3.0.0 Aug 15, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carusogabriel carusogabriel carusogabriel approved these changes

@greg0ire greg0ire Awaiting requested review from greg0ire

Assignees

@morozov morozov

Labels
Code Style Improvement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@morozov @carusogabriel