PostgreSQL renameColumn - ........pg.dropped.x.......

[kamil-michalak]

When we have table with deleted columns and we wanna renameColumn this deleted column is still fetched by getListTableColumnsSQL and Dbal cannot fetch type for this column and cast them to anyelement. Maybe in sql should be additonal condition attisdropped=false to avoid this kind of situation?

dbal/src/Platforms/PostgreSQLPlatform.php

Lines 450 to 483 in 6a793fb

	public function getListTableColumnsSQL($table, $database = null)
	{
	return "SELECT
	a.attnum,
	quote_ident(a.attname) AS field,
	t.typname AS type,
	format_type(a.atttypid, a.atttypmod) AS complete_type,
	(SELECT tc.collcollate FROM pg_catalog.pg_collation tc WHERE tc.oid = a.attcollation) AS collation,
	(SELECT t1.typname FROM pg_catalog.pg_type t1 WHERE t1.oid = t.typbasetype) AS domain_type,
	(SELECT format_type(t2.typbasetype, t2.typtypmod) FROM
	pg_catalog.pg_type t2 WHERE t2.typtype = 'd' AND t2.oid = a.atttypid) AS domain_complete_type,
	a.attnotnull AS isnotnull,
	(SELECT 't'
	FROM pg_index
	WHERE c.oid = pg_index.indrelid
	AND pg_index.indkey[0] = a.attnum
	AND pg_index.indisprimary = 't'
	) AS pri,
	(SELECT pg_get_expr(adbin, adrelid)
	FROM pg_attrdef
	WHERE c.oid = pg_attrdef.adrelid
	AND pg_attrdef.adnum=a.attnum
	) AS default,
	(SELECT pg_description.description
	FROM pg_description WHERE pg_description.objoid = c.oid AND a.attnum = pg_description.objsubid
	) AS comment
	FROM pg_attribute a, pg_class c, pg_type t, pg_namespace n
	WHERE " . $this->getTableWhereClause($table, 'c', 'n') . '
	AND a.attnum > 0
	AND a.attrelid = c.oid
	AND a.atttypid = t.oid
	AND n.oid = c.relnamespace
	ORDER BY a.attnum';
	}

[derrabus]

Sounds good, please send a PR.