🐛 bugfix/#6261 - Allow (also for DATETIME) dynamic intervals in DATE_…

…ADD & DATE_SUB for SQLite - 🐛 Fix code divergence - ✅ Add related tests
doctrine · Jan 12, 2024 · 843719c · 843719c
1 parent 6a793fb
commit 843719c
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/src/Platforms/SqlitePlatform.php b/src/Platforms/SqlitePlatform.php
@@ -152,6 +152,10 @@ protected function getDateArithmeticIntervalExpression($date, $operator, $interv
             case DateIntervalUnit::SECOND:
             case DateIntervalUnit::MINUTE:
             case DateIntervalUnit::HOUR:
+                if (! is_numeric($interval)) {
+                    $interval = "' || " . $interval . " || '";
+                }
+
                 return 'DATETIME(' . $date . ",'" . $operator . $interval . ' ' . $unit . "')";
         }
 

diff --git a/tests/Platforms/SqlitePlatformTest.php b/tests/Platforms/SqlitePlatformTest.php
@@ -733,6 +733,22 @@ public function testQuotesDropForeignKeySQL(): void
         $this->markTestSkipped('SQLite does not support altering foreign key constraints.');
     }
 
+    public function testDateAddStaticNumberOfMinutes(): void
+    {
+        self::assertSame(
+            "DATETIME(endAt,'+12 MINUTE')",
+            $this->platform->getDateAddMinutesExpression('endAt', 12),
+        );
+    }
+
+    public function testDateAddNumberOfMinutesFromColumn(): void
+    {
+        self::assertSame(
+            "DATETIME(endAt,'+' || duration || ' MINUTE')",
+            $this->platform->getDateAddMinutesExpression('endAt', 'duration'),
+        );
+    }
+
     public function testDateAddStaticNumberOfDays(): void
     {
         self::assertSame(