Skip to content

Commit

Permalink
Merge pull request #4589 from PowerKiKi/paren
Browse files Browse the repository at this point in the history
Reference methods using parentheses
  • Loading branch information
morozov committed Apr 8, 2021
2 parents 3ea7e73 + 8163106 commit 7c7efbe
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions src/Query/QueryBuilder.php
Expand Up @@ -628,7 +628,7 @@ public function select($select = null/*, string ...$selects*/)
Deprecation::trigger(
'doctrine/dbal',
'https://github.com/doctrine/dbal/issues/3837',
'Passing an array for the first argument to QueryBuilder::select is deprecated, ' .
'Passing an array for the first argument to QueryBuilder::select() is deprecated, ' .
'pass each value as an individual variadic argument instead.'
);
}
Expand Down Expand Up @@ -687,7 +687,7 @@ public function addSelect($select = null/*, string ...$selects*/)
Deprecation::trigger(
'doctrine/dbal',
'https://github.com/doctrine/dbal/issues/3837',
'Passing an array for the first argument to QueryBuilder::addSelect is deprecated, ' .
'Passing an array for the first argument to QueryBuilder::addSelect() is deprecated, ' .
'pass each value as an individual variadic argument instead.'
);
}
Expand Down Expand Up @@ -1068,7 +1068,7 @@ public function groupBy($groupBy/*, string ...$groupBys*/)
Deprecation::trigger(
'doctrine/dbal',
'https://github.com/doctrine/dbal/issues/3837',
'Passing an array for the first argument to QueryBuilder::groupBy is deprecated, ' .
'Passing an array for the first argument to QueryBuilder::groupBy() is deprecated, ' .
'pass each value as an individual variadic argument instead.'
);
}
Expand Down Expand Up @@ -1106,7 +1106,7 @@ public function addGroupBy($groupBy/*, string ...$groupBys*/)
Deprecation::trigger(
'doctrine/dbal',
'https://github.com/doctrine/dbal/issues/3837',
'Passing an array for the first argument to QueryBuilder::addGroupBy is deprecated, ' .
'Passing an array for the first argument to QueryBuilder::addGroupBy() is deprecated, ' .
'pass each value as an individual variadic argument instead.'
);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Schema/AbstractSchemaManager.php
Expand Up @@ -232,7 +232,7 @@ public function tablesExist($names)
Deprecation::trigger(
'doctrine/dbal',
'https://github.com/doctrine/dbal/issues/3580',
'The usage of a string $tableNames in AbstractSchemaManager::tablesExist is deprecated. ' .
'The usage of a string $tableNames in AbstractSchemaManager::tablesExist() is deprecated. ' .
'Pass a one-element array instead.'
);
}
Expand Down
4 changes: 2 additions & 2 deletions tests/Platforms/SqlitePlatformTest.php
Expand Up @@ -591,15 +591,15 @@ protected function getQuotedAlterTableChangeColumnLengthSQL(): array
public function testAlterTableRenameIndexInSchema(): void
{
self::markTestIncomplete(
'Test currently produces broken SQL due to SQLLitePlatform::getAlterTable being broken ' .
'Test currently produces broken SQL due to SQLLitePlatform::getAlterTable() being broken ' .
'when used with schemas.'
);
}

public function testQuotesAlterTableRenameIndexInSchema(): void
{
self::markTestIncomplete(
'Test currently produces broken SQL due to SQLLitePlatform::getAlterTable being broken ' .
'Test currently produces broken SQL due to SQLLitePlatform::getAlterTable() being broken ' .
'when used with schemas.'
);
}
Expand Down

0 comments on commit 7c7efbe

Please sign in to comment.