Skip to content

Commit

Permalink
Reworked driver exception tests
Browse files Browse the repository at this point in the history
1. Got rid of hard-coded exception mocks in favor of PHPUnit-generated ones where possible.
2. Reworked AbstractDriverTest::testConvertsException() to use a data provider to make testing all types of exceptions independent.
3. Updated PHPUnit since the reworked code relies on sebastianbergmann/phpunit#3604.
  • Loading branch information
morozov committed May 16, 2019
1 parent 4d0d2af commit 6327727
Show file tree
Hide file tree
Showing 9 changed files with 132 additions and 162 deletions.
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"doctrine/coding-standard": "^6.0",
"jetbrains/phpstorm-stubs": "^2018.1.2",
"phpstan/phpstan": "^0.11.3",
"phpunit/phpunit": "^8.0",
"phpunit/phpunit": "^8.1.5",
"symfony/console": "^2.0.5|^3.0|^4.0",
"symfony/phpunit-bridge": "^3.4.5|^4.0.5"
},
Expand Down
124 changes: 63 additions & 61 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 6327727

Please sign in to comment.