Add UT & fix a bug

doctrine · Apr 12, 2021 · 5663448 · 5663448
1 parent d844ed5
commit 5663448
Show file tree

Hide file tree

Showing 2 changed files with 118 additions and 4 deletions.
diff --git a/lib/Doctrine/DBAL/ForwardCompatibility/Result.php b/lib/Doctrine/DBAL/ForwardCompatibility/Result.php
@@ -398,7 +398,7 @@ public function execute($params = null)
         );
 
         if ($this->stmt instanceof DriverStatement) {
-            return $this->stmt->execute();
+            return $this->stmt->execute($params);
         }
 
         throw Exception::notSupported('execute');

diff --git a/tests/Doctrine/Tests/DBAL/ForwardCompatibility/ResultTest.php b/tests/Doctrine/Tests/DBAL/ForwardCompatibility/ResultTest.php
@@ -3,9 +3,10 @@
 namespace Doctrine\Tests\DBAL\ForwardCompatibility;
 
 use Doctrine\DBAL\Cache\ArrayStatement;
-use Doctrine\DBAL\Driver\ResultStatement as DriverResultStatement;
+use Doctrine\DBAL\Driver;
 use Doctrine\DBAL\Exception;
 use Doctrine\DBAL\ForwardCompatibility\Result;
+use Doctrine\DBAL\ParameterType;
 use PDO;
 use PHPUnit\Framework\TestCase;
 use Traversable;
@@ -335,15 +336,128 @@ public function testIterateColumn(): void
         );
     }
 
-    public function testRowCountIsSupportedByWrappedStatement(): void
+    public function testRowCountIsSupportedByWrappedArrayStatement(): void
     {
         $this->assertSame(3, $this->instance->rowCount());
     }
 
     public function testRowCountIsNotSupportedByWrappedStatement(): void
     {
         $this->expectExceptionObject(Exception::notSupported('rowCount'));
-        $instance = new Result($this->createMock(DriverResultStatement::class));
+        $instance = new Result($this->createMock(Driver\ResultStatement::class));
         $instance->rowCount();
     }
+
+    public function testBindValueIsSupportedByWrappedStatement(): void
+    {
+        $param = ':key';
+        $value = 'value';
+
+        $statement = $this->createMock(Driver\Statement::class);
+        $statement
+            ->expects($this->once())
+            ->method('bindValue')
+            ->with($param, $value, ParameterType::STRING)
+            ->willReturn(true);
+
+        $instance = new Result($statement);
+
+        $this->assertTrue($instance->bindValue($param, $value));
+    }
+
+    public function testBindValueIsNotSupportedByWrappedResultStatement(): void
+    {
+        $this->expectExceptionObject(Exception::notSupported('bindValue'));
+        $this->instance->bindValue(':key', 'value');
+    }
+
+    public function testBindParamIsSupportedByWrappedStatement(): void
+    {
+        $param = ':key';
+        $value = 'value';
+
+        $statement = $this->createMock(Driver\Statement::class);
+        $statement
+            ->expects($this->once())
+            ->method('bindParam')
+            ->with($param, $value, ParameterType::STRING)
+            ->willReturn(true);
+
+        $instance = new Result($statement);
+
+        $this->assertTrue($instance->bindParam($param, $value));
+    }
+
+    public function testBindParamIsNotSupportedByWrappedResultStatement(): void
+    {
+        $param = ':key';
+        $value = 'value';
+
+        $this->expectExceptionObject(Exception::notSupported('bindParam'));
+        $this->instance->bindParam($param, $value);
+    }
+
+    public function testErrorCodeIsSupportedByWrappedStatement(): void
+    {
+        $errorCode = 32;
+
+        $statement = $this->createMock(Driver\Statement::class);
+        $statement
+            ->expects($this->once())
+            ->method('errorCode')
+            ->willReturn($errorCode);
+
+        $instance = new Result($statement);
+
+        $this->assertSame($errorCode, $instance->errorCode());
+    }
+
+    public function testErrorCodeIsNotSupportedByWrappedResultStatement(): void
+    {
+        $this->expectExceptionObject(Exception::notSupported('errorCode'));
+        $this->instance->errorCode();
+    }
+
+    public function testErrorInfoIsSupportedByWrappedStatement(): void
+    {
+        $errorInfo = ['Some info'];
+
+        $statement = $this->createMock(Driver\Statement::class);
+        $statement
+            ->expects($this->once())
+            ->method('errorInfo')
+            ->willReturn($errorInfo);
+
+        $instance = new Result($statement);
+
+        $this->assertSame($errorInfo, $instance->errorInfo());
+    }
+
+    public function testErrorInfoIsNotSupportedByWrappedResultStatement(): void
+    {
+        $this->expectExceptionObject(Exception::notSupported('errorInfo'));
+        $this->instance->errorInfo();
+    }
+
+    public function testExecuteIsSupportedByWrappedStatement(): void
+    {
+        $params = [':key' => 'value'];
+
+        $statement = $this->createMock(Driver\Statement::class);
+        $statement
+            ->expects($this->once())
+            ->method('execute')
+            ->with($params)
+            ->willReturn(true);
+
+        $instance = new Result($statement);
+
+        $this->assertTrue($instance->execute($params));
+    }
+
+    public function testExecuteIsNotSupportedByWrappedResultStatement(): void
+    {
+        $this->expectExceptionObject(Exception::notSupported('execute'));
+        $this->instance->execute([':key' => 'value']);
+    }
 }