Improve API by removing nullability

doctrine · Apr 5, 2021 · 499199f · 499199f
1 parent 8a502f3
commit 499199f
Showing 1 changed file with 14 additions and 6 deletions.
diff --git a/lib/Doctrine/DBAL/Statement.php b/lib/Doctrine/DBAL/Statement.php
@@ -193,12 +193,16 @@ public function execute($params = null)
     /**
      * Executes the statement with the currently bound parameters and return result.
      *
-     * @param mixed[]|null $params
-
+     * @param mixed[] $params
+     *
      * @throws Exception
      */
-    public function executeQuery(?array $params = null): BaseResult
+    public function executeQuery(array $params = []): BaseResult
     {
+        if ($params === []) {
+            $params = null; // Workaround as long execute() exists and used internally.
+        }
+
         $this->execute($params);
 
         return new ForwardCompatibility\Result($this);
@@ -207,12 +211,16 @@ public function executeQuery(?array $params = null): BaseResult
     /**
      * Executes the statement with the currently bound parameters and return affected rows.
      *
-     * @param mixed[]|null $params
-
+     * @param mixed[] $params
+     *
      * @throws Exception
      */
-    public function executeStatement(?array $params = null): int
+    public function executeStatement(array $params = []): int
     {
+        if ($params === []) {
+            $params = null; // Workaround as long execute() exists and used internally.
+        }
+
         $this->execute($params);
 
         return $this->rowCount();