Skip to content

Commit

Permalink
Merge pull request #5568 from morozov/pre-release-documentation
Browse files Browse the repository at this point in the history
Mark remaining schema introspection platform methods as internal
  • Loading branch information
morozov committed Aug 6, 2022
2 parents eb78575 + ca2160d commit 1c5d39c
Show file tree
Hide file tree
Showing 8 changed files with 40 additions and 0 deletions.
8 changes: 8 additions & 0 deletions UPGRADE.md
Expand Up @@ -289,6 +289,14 @@ The following schema introspection methods have been deprecated:
- `AbstractPlatform::getListTableIndexesSQL()`,
- `AbstractPlatform::getListTableForeignKeysSQL()`.

## `AbstractPlatform` schema introspection methods made internal

The following schema introspection methods have been marked as internal:

- `AbstractPlatform::getListDatabasesSQL()`,
- `AbstractPlatform::getListSequencesSQL()`,
- `AbstractPlatform::getListViewsSQL()`.

The queries used for schema introspection are an internal implementation detail of the DBAL.

## Deprecated `collate` option for MySQL
Expand Down
4 changes: 4 additions & 0 deletions src/Platforms/AbstractMySQLPlatform.php
Expand Up @@ -143,6 +143,8 @@ public function getLengthExpression($column)

/**
* {@inheritDoc}
*
* @internal The method should be only used from within the {@see AbstractSchemaManager} class hierarchy.
*/
public function getListDatabasesSQL()
{
Expand Down Expand Up @@ -182,6 +184,8 @@ public function getListTableIndexesSQL($table, $database = null)

/**
* {@inheritDoc}
*
* @internal The method should be only used from within the {@see AbstractSchemaManager} class hierarchy.
*/
public function getListViewsSQL($database)
{
Expand Down
6 changes: 6 additions & 0 deletions src/Platforms/AbstractPlatform.php
Expand Up @@ -3444,6 +3444,8 @@ protected function _getTransactionIsolationLevelSQL($level)
}

/**
* @internal The method should be only used from within the {@see AbstractSchemaManager} class hierarchy.
*
* @return string
*
* @throws Exception If not supported on this platform.
Expand Down Expand Up @@ -3475,6 +3477,8 @@ public function getListNamespacesSQL()
}

/**
* @internal The method should be only used from within the {@see AbstractSchemaManager} class hierarchy.
*
* @param string $database
*
* @return string
Expand Down Expand Up @@ -3548,6 +3552,8 @@ public function getListUsersSQL()
/**
* Returns the SQL to list all views of a database or user.
*
* @internal The method should be only used from within the {@see AbstractSchemaManager} class hierarchy.
*
* @param string $database
*
* @return string
Expand Down
2 changes: 2 additions & 0 deletions src/Platforms/DB2Platform.php
Expand Up @@ -396,6 +396,8 @@ public function getListTablesSQL()

/**
* {@inheritDoc}
*
* @internal The method should be only used from within the {@see AbstractSchemaManager} class hierarchy.
*/
public function getListViewsSQL($database)
{
Expand Down
6 changes: 6 additions & 0 deletions src/Platforms/OraclePlatform.php
Expand Up @@ -415,6 +415,8 @@ public function getClobTypeDeclarationSQL(array $column)

/**
* {@inheritDoc}
*
* @internal The method should be only used from within the {@see AbstractSchemaManager} class hierarchy.
*/
public function getListDatabasesSQL()
{
Expand All @@ -423,6 +425,8 @@ public function getListDatabasesSQL()

/**
* {@inheritDoc}
*
* @internal The method should be only used from within the {@see AbstractSchemaManager} class hierarchy.
*/
public function getListSequencesSQL($database)
{
Expand Down Expand Up @@ -518,6 +522,8 @@ public function getListTablesSQL()

/**
* {@inheritDoc}
*
* @internal The method should be only used from within the {@see AbstractSchemaManager} class hierarchy.
*/
public function getListViewsSQL($database)
{
Expand Down
6 changes: 6 additions & 0 deletions src/Platforms/PostgreSQLPlatform.php
Expand Up @@ -266,6 +266,8 @@ public function hasNativeGuidType()

/**
* {@inheritDoc}
*
* @internal The method should be only used from within the {@see AbstractSchemaManager} class hierarchy.
*/
public function getListDatabasesSQL()
{
Expand Down Expand Up @@ -294,6 +296,8 @@ public function getListNamespacesSQL()

/**
* {@inheritDoc}
*
* @internal The method should be only used from within the {@see AbstractSchemaManager} class hierarchy.
*/
public function getListSequencesSQL($database)
{
Expand Down Expand Up @@ -326,6 +330,8 @@ public function getListTablesSQL()

/**
* {@inheritDoc}
*
* @internal The method should be only used from within the {@see AbstractSchemaManager} class hierarchy.
*/
public function getListViewsSQL($database)
{
Expand Down
6 changes: 6 additions & 0 deletions src/Platforms/SQLServerPlatform.php
Expand Up @@ -190,6 +190,8 @@ public function getCreateSequenceSQL(Sequence $sequence): string

/**
* {@inheritdoc}
*
* @internal The method should be only used from within the {@see AbstractSchemaManager} class hierarchy.
*/
public function getListSequencesSQL($database)
{
Expand Down Expand Up @@ -1040,6 +1042,8 @@ public function getListTableIndexesSQL($table, $database = null)

/**
* {@inheritDoc}
*
* @internal The method should be only used from within the {@see AbstractSchemaManager} class hierarchy.
*/
public function getListViewsSQL($database)
{
Expand Down Expand Up @@ -1137,6 +1141,8 @@ public function getConcatExpression()

/**
* {@inheritDoc}
*
* @internal The method should be only used from within the {@see AbstractSchemaManager} class hierarchy.
*/
public function getListDatabasesSQL()
{
Expand Down
2 changes: 2 additions & 0 deletions src/Platforms/SqlitePlatform.php
Expand Up @@ -573,6 +573,8 @@ public function getListTablesSQL()

/**
* {@inheritDoc}
*
* @internal The method should be only used from within the {@see AbstractSchemaManager} class hierarchy.
*/
public function getListViewsSQL($database)
{
Expand Down

0 comments on commit 1c5d39c

Please sign in to comment.