Allow dependent fixtures to reference other types of fixture without triggering an error. #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhpStorm shows an error. I think it's because ObjectManager was already imported.
Updated incorrect PhpDoc
addReference() actually throws exception
…et managed my UnitOfWork.
Add explicit visibility for function load
Syntax highlighting on README.md
…pes of fixture without triggering Notice errors while sequencing
|
Can you rebase and provide a test for this? I am not sure it is still needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When mixing ordered and dependent fixtures, if a dependent fixture references an ordered fixture in getDependencies it triggers an error during loading. This is because the ordered fixtures are not included in the list of classes that need to be sequenced, triggering a Notice error when using the class name as an array index.
This fix checks to see if the class name exists in the array before checking if it has been sequenced already.