Proxy generating __sleep with uninitialized properties (PHP7.4.2+)

[bizley]

Proxy generator is creating __sleep method with uninitialized typed properties which is a critical bug since PHP 7.4.2 (https://bugs.php.net/bug.php?id=79002) ending in message:

Typed property Proxies_CG_\App\Entity\EntityName::$ must not be accessed before initialization (in __sleep)

I've already reported it (not knowing the source of error hence the wrong repo) in doctrine/orm#8030 but it looks like it's stuck there forgotten.

[2ec0b4]

I'm stuck with the same error. I manage to reproduce it with the smallest Symfony project. Here it is: https://github.com/2ec0b4/symfony-proxy-issue

[sebastianlew]

I wanted to make PR fixing that problem, but i think it isn't as simple as we think :)

Few ideas i had:

1. Maybe solution is to serialize just identifier if entity is not initialized yet. I tested it, it seems work in most cases, but what with case when we serialize uninitialized entity, and then try to unserialize and access different property? Same problem, we also get an error that property is not initialized.

2. Second solution is to initialize whole entity in _sleep before we serialize it. But i think this can really affect performance, so the first one sounds better for me. The question is if it is possible and how it could run in wider context if we serialize just identifier when entity is not initialized by doctrine

[nicolas-grekas]

To me, a fix should be considered at the PHP level, I opened https://bugs.php.net/79447 🤞

[sebastianlew]

@nicolas-grekas That’s why I wrote

I wanted to make PR fixing that problem, but i think it isn't as simple as we think :)

cause i didn’t see any perfect solution to solve this problem directly in doctrine 😁

[nicolas-grekas]

php/php-src#5396 will be part of PHP 7.4.6, thus nothing to do here.

[sebastianlew]

@nicolas-grekas I saw that problem escalated a little and also your PR was closed on php src. Will that problem be fixed soon in php src? What's the state of this problem for now ?

[nicolas-grekas]

Give PHP 7.4.6 a try, it's been released yesterday.

[sebastianlew]

Everything works fine now 🎉 , thank you @nicolas-grekas

[Ocramius]

Probably best to add an exclusion range for 7.4.0~7.4.5

[alcaeus]

Probably best to add an exclusion range for 7.4.0~7.4.5

That won't help: any release without this exclusion is still eligible but also suffers from the problem. This is not our problem to fix.

[Ocramius]

It would still make upgrading to latest version clear and blocked off until 7.4.6 is installed (good).

This has been done for similar reasons in:

• https://github.com/Ocramius/ProxyManager/releases/tag/2.7.1
• https://github.com/Ocramius/ProxyManager/releases/tag/2.8.0

Overall, it provides guidance for downstream, and this package is indeed still broken in 7.4.0~7.4.5.

[sebastianlew]

I think that first step also could be improvement of the tests in doctrine/common cause despite this problem tests have been passing for e.g. tests/Doctrine/Tests/Common/Proxy/LazyLoadableObjectWithTypedProperties.php (I'll try to do it if nobody do it first)

EDIT: I know that problem was fixed in php-src directly, and doctrine/common shouldn't check functionalities that are in php-src, but still in my opinion this test doesn't verify a lot of cases

[beberlei]

Closing as its a PHP bug.