Merge 9.0.x up into 10.0.x #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ci: run checks on php 8.0 and 8.1
We cannot run multiple update-compatibility-patch-* make targets at the same time so there's no need for having php version suffix in tmp-patch filename
…desniffer v3.7 - Bump min php to 7.2
chore(deps): require slevomat/coding-standard v8 and squizlabs/php_codesniffer v3.7
|
What you did is correct, but you need to fix the build now. |
simPod
force-pushed
the
merge
branch
11 times, most recently
from
7093af8
to
995c202
Compare
ostrolucky
previously approved these changes
Jun 26, 2022
malarzm
previously approved these changes
Jun 26, 2022
|
@simPod can you adjust the PR title to match meaning? For release notes |
|
@Ocramius what about now |
|
Ok, then it seems wrong to do this :D |
|
lol I messed up. Now it's correct. |
Ocramius
previously approved these changes
Jun 26, 2022
simPod
dismissed stale reviews from Ocramius, malarzm, and ostrolucky
via
141db49
simPod
commented
Jun 26, 2022
# Conflicts: # Makefile # tests/php74-compatibility.patch # tests/php80-compatibility.patch
Ocramius
approved these changes
Jun 26, 2022
ostrolucky
approved these changes
Jun 26, 2022
malarzm
approved these changes
Jun 26, 2022
|
Thanks @simPod! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@greg0ire How to process this properly? I'd need #269 to be include in 10.0.x branch.