Still works on PHP 7.1

[beberlei]

Restricting the 8.1 branch to 7.1 is an artificial constraint, the code works on 7.1 just fine.

#127 removed 7.1 support, but slevomat/coding-standard reintroduced 7.1 support with slevomat/coding-standard@b26cb5c#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34

[greg0ire]

Should 7.1 be added to

coding-standard/.github/workflows/continuous-integration.yml

Lines 92 to 95 in b27f98f

	php-version:
	- "7.2"
	- "7.3"
	- "7.4"

?

Should this be changed to 7.1?

coding-standard/.github/workflows/continuous-integration.yml

Line 128 in b27f98f

- "7.2"

[beberlei]

@greg0ire yes to both, added and works.

[greg0ire]

Note to the person that merges this: you will have to mark "Test fixes (7.2)" as no longer required, and the new 7.1 jobs as required in the settings just before merging this.

[greg0ire]

Thanks @beberlei !

[greg0ire]

Ah crap, this shouldn't have been merged in 8.1.x, it's not a bugfix… Also, master is aliased to 7.0.x 🤦
Let me figure out if master has any BC-breaking changes and I will figure out what to do from there.

[beberlei]

@greg0ire you could argue its a bugfix, as 7.1 support was wrongly removed :-)

[greg0ire]

Yeah sure. I think there are no BC-breaks on master. Also, master has f6d859e , which I believe would have also solved the CI issue we had 😆 . I will merge 8.1x into master, then rename master to 8.2.x, and then we can release 8.2.0