Enable DisallowArrayTypeHintSyntax sniff

[simPod]

Disallows usage of array type hint syntax (eg. int[], bool[][]) in phpDocs in favour of generic type hint syntax (eg. array, array<array>).

• added new sniff
• fixed violations in all tests
• added type-hints test to cover this (+2 errors, autoloading and string[] violation)

If this passes, I can drop all traversableTypeHints settings from #139 (review)

[ostrolucky]

PHPStorm does not understand this, that's a no go

[alcaeus]

Agree with @ostrolucky here: until current tooling understands the generic syntax, we shouldn't enforce this in doctrine/cs.

[simPod]

Makes sense. Thanks

[lcobucci]

PHPStorm does understand that syntax: https://blog.jetbrains.com/phpstorm/2018/09/phpstorm-2018-3-eap-183-2635-12/ - that's just for reference not that we must enforce it now 😄

[ostrolucky]

Only on parser level. You will not get $foo-> autocompletion for such annotations

[simPod]

Yea, don't know why they published the article, it's deceptive. PHPStorm does not complain about the syntax, but that's it 😄

[simPod]

This one is in their top 10 most voted issues for phpstorm but from information they gave me it's not even planned yet https://youtrack.jetbrains.com/issue/WI-43843

[Ocramius]

In my case, I started adding two sets of annotations (to be removed later on), such as @var for the IDE, @psalm-var for the actual type:

/**
 * @var Collection|Foo[] - notw that this type is invalid
 * @psalm-var Collection<String, Foo>
 */

I'm hoping for the IDE to catch up, and then I'd do a find/replace