Camel case vars #128
Merged
Camel case vars #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should the drop of PHP 7.1 put into another PR instead if this one? Or was this necessary to be able to introduce the new rule? |
|
This can now be rebased atop new |
|
This was necessary for CI to pass as it was not merged at the time of opening this PR. Rebasing now. |
SenseException
approved these changes
Jul 2, 2019
carusogabriel
suggested changes
Jul 2, 2019
carusogabriel
approved these changes
Jul 2, 2019
There was a problem hiding this comment.
Something to note: DBAL, for example, has protected properties with a leading underscore:
FILE: lib/Doctrine/DBAL/Schema/AbstractSchemaManager.php
-------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------
38 | ERROR | Protected member variable "_conn" must not contain a leading underscore
| | (Squiz.NamingConventions.ValidVariableName.PublicHasUnderscore)
45 | ERROR | Protected member variable "_platform" must not contain a leading underscore
| | (Squiz.NamingConventions.ValidVariableName.PublicHasUnderscore)
-------------------------------------------------------------------------------------------------------------------------------------------------------
changing that might result in a BC, but we can ignore this new rule there, the same way we do with ODM and classes names conventions:
malarzm
approved these changes
Jul 2, 2019
deeky666
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed there was no sniff enabled to force camelCase variable names.
I cannot create issue to ask so I created this PR. Is there a reason for absence of such rule or is this PR actually viable? Eg. methodNames() or ClassNames are required to be camelCased.