feat: enforce spaces between constants

doctrine · Jul 10, 2022 · f0ae45f · f0ae45f
1 parent 51e2045
commit f0ae45f
Show file tree

Hide file tree

Showing 8 changed files with 30 additions and 5 deletions.
diff --git a/lib/Doctrine/ruleset.xml b/lib/Doctrine/ruleset.xml
@@ -122,6 +122,8 @@
             <property name="fixable" value="true"/>
         </properties>
     </rule>
+    <!-- Enforce consistent constant spacing -->
+    <rule ref="SlevomatCodingStandard.Classes.ConstantSpacing"/>
     <!-- Forbid LSB for constants (static::FOO) -->
     <rule ref="SlevomatCodingStandard.Classes.DisallowLateStaticBindingForConstants"/>
     <!-- Forbid more than one constant declared per statement -->

diff --git a/tests/expected_report.txt b/tests/expected_report.txt
@@ -48,7 +48,7 @@ tests/input/UselessConditions.php                     20      0
 ----------------------------------------------------------------------
 A TOTAL OF 381 ERRORS AND 0 WARNINGS WERE FOUND IN 42 FILES
 ----------------------------------------------------------------------
-PHPCBF CAN FIX 315 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
+PHPCBF CAN FIX 316 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
 ----------------------------------------------------------------------
 
 
diff --git a/tests/fixed/constants-var.php b/tests/fixed/constants-var.php
@@ -4,6 +4,8 @@
 
 namespace ConstantsVar;
 
+// phpcs:disable PSR1.Classes.ClassDeclaration.MultipleClasses, Squiz.Classes.ClassFileName.NoMatch
+
 const FOO = 123;
 
 const BAR_1 = 1;
@@ -16,3 +18,12 @@ class Bar
     protected const PROPERTY_1 = '1';
     protected const PROPERTY_2 = '2';
 }
+
+
+class Spacing
+{
+    public const FOO = 'bar';
+    public const BAR = 'bar';
+
+    public const BAZ = 'baz';
+}
diff --git a/tests/input/constants-var.php b/tests/input/constants-var.php
@@ -4,6 +4,8 @@
 
 namespace ConstantsVar;
 
+// phpcs:disable PSR1.Classes.ClassDeclaration.MultipleClasses, Squiz.Classes.ClassFileName.NoMatch
+
 /** @var int */
 const FOO = 123;
 
@@ -16,3 +18,13 @@ class Bar
 
     protected const PROPERTY_1 = '1', PROPERTY_2 = '2';
 }
+
+
+class Spacing
+{
+    public const FOO = 'bar';
+    public const BAR = 'bar';
+
+
+    public const BAZ = 'baz';
+}
diff --git a/tests/php73-compatibility.patch b/tests/php73-compatibility.patch
@@ -17,7 +17,7 @@ index 1d5a7d3..fae9e70 100644
 -A TOTAL OF 381 ERRORS AND 0 WARNINGS WERE FOUND IN 42 FILES
 +A TOTAL OF 383 ERRORS AND 0 WARNINGS WERE FOUND IN 43 FILES
  ----------------------------------------------------------------------
--PHPCBF CAN FIX 315 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
+-PHPCBF CAN FIX 316 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
 +PHPCBF CAN FIX 317 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
  ----------------------------------------------------------------------
 

diff --git a/tests/php74-compatibility.patch b/tests/php74-compatibility.patch
@@ -39,7 +39,7 @@ index 1d5a7d3..91e97e7 100644
 -A TOTAL OF 381 ERRORS AND 0 WARNINGS WERE FOUND IN 42 FILES
 +A TOTAL OF 392 ERRORS AND 0 WARNINGS WERE FOUND IN 43 FILES
  ----------------------------------------------------------------------
--PHPCBF CAN FIX 315 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
+-PHPCBF CAN FIX 316 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
 +PHPCBF CAN FIX 326 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
  ----------------------------------------------------------------------
 

diff --git a/tests/php80-compatibility.patch b/tests/php80-compatibility.patch
@@ -52,7 +52,7 @@ index 1d5a7d3..03460f2 100644
 -A TOTAL OF 381 ERRORS AND 0 WARNINGS WERE FOUND IN 42 FILES
 +A TOTAL OF 420 ERRORS AND 0 WARNINGS WERE FOUND IN 44 FILES
  ----------------------------------------------------------------------
--PHPCBF CAN FIX 315 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
+-PHPCBF CAN FIX 316 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
 +PHPCBF CAN FIX 354 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
  ----------------------------------------------------------------------
 

diff --git a/tests/php81-compatibility.patch b/tests/php81-compatibility.patch
@@ -53,7 +53,7 @@ index 1d5a7d3..e9394b1 100644
 -A TOTAL OF 381 ERRORS AND 0 WARNINGS WERE FOUND IN 42 FILES
 +A TOTAL OF 426 ERRORS AND 0 WARNINGS WERE FOUND IN 45 FILES
  ----------------------------------------------------------------------
--PHPCBF CAN FIX 315 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
+-PHPCBF CAN FIX 316 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
 +PHPCBF CAN FIX 360 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
  ----------------------------------------------------------------------