feat: enforce spaces between constants

doctrine · Jun 27, 2022 · 982dae0 · 982dae0
1 parent 0f64bb0
commit 982dae0
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 1 deletion.
diff --git a/lib/Doctrine/ruleset.xml b/lib/Doctrine/ruleset.xml
@@ -120,6 +120,8 @@
             <property name="fixable" value="true"/>
         </properties>
     </rule>
+    <!-- Enforce consistent constant spacing -->
+    <rule ref="SlevomatCodingStandard.Classes.ConstantSpacing"/>
     <!-- Forbid LSB for constants (static::FOO) -->
     <rule ref="SlevomatCodingStandard.Classes.DisallowLateStaticBindingForConstants"/>
     <!-- Forbid more than one constant declared per statement -->

diff --git a/tests/expected_report.txt b/tests/expected_report.txt
@@ -10,7 +10,7 @@ tests/input/binary_operators.php                      9       0
 tests/input/class-references.php                      10      0
 tests/input/concatenation_spacing.php                 49      0
 tests/input/constants-no-lsb.php                      2       0
-tests/input/constants-var.php                         6       0
+tests/input/constants-var.php                         12       0
 tests/input/ControlStructures.php                     28      0
 tests/input/doc-comment-spacing.php                   11      0
 tests/input/duplicate-assignment-variable.php         1       0

diff --git a/tests/fixed/constants-var.php b/tests/fixed/constants-var.php
@@ -16,3 +16,17 @@ class Bar
     protected const PROPERTY_1 = '1';
     protected const PROPERTY_2 = '2';
 }
+
+// phpcs:disable SlevomatCodingStandard.TypeHints.UselessConstantTypeHint.UselessDocComment
+
+class Spacing
+{
+    /** @var string */
+    public const FOO = 'bar';
+
+    /** @var string */
+    public const BAR = 'bar';
+    public const BAZ = 'baz';
+
+    public const BAM = 'bam';
+}
diff --git a/tests/input/constants-var.php b/tests/input/constants-var.php
@@ -16,3 +16,17 @@ class Bar
 
     protected const PROPERTY_1 = '1', PROPERTY_2 = '2';
 }
+
+// phpcs:disable SlevomatCodingStandard.TypeHints.UselessConstantTypeHint.UselessDocComment
+
+class Spacing
+{
+    /** @var string */
+    public const FOO = 'bar';
+    /** @var string */
+    public const BAR = 'bar';
+    public const BAZ = 'baz';
+
+
+    public const BAM = 'bam';
+}