Flush deferred items array on commit #387
Merged
+19
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once the items have been flushed to the wrapped cache, they should be removed from the internal buffer so that: - they are not flushed again on subsequent calls to commit() - the memory they take is freed. Fixes doctrine#386
greg0ire
force-pushed
the
plug-memory-leak
branch
from
af5c488 to
6aed354
Compare
derrabus
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once the items have been flushed to the wrapped cache, they should be
removed from the internal buffer so that:
Fixes #386
How can I test this?
composer config repositories.greg0ire vcs https://github.com/greg0ire/cache-1 composer require doctrine/cache "dev-plug-memory-leak as 1.12.0"or
composer config repositories.greg0ire vcs https://github.com/greg0ire/cache-1 composer require doctrine/cache "dev-plug-memory-leak as 2.1.0"depending on what you are currently using.